Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Don't query chain in Signer, use Redux isTest #3524

Merged
merged 4 commits into from
Nov 21, 2016
Merged

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 18, 2016

No functionality changed, but allows me to break up the Signer changes into smaller chunks.

This one (1 of n) gets rids of the uneeded queries for chain in the Signer. We have the information available on Redux, so no need to make extra queries for each component needing the information. As a bonus the chain === 'testnet' || chain === 'morden' change is now only done in one place in the UI, so it cleans up the codebase.

In short: don't query for chain per component and pass it along the chain, use the global state that indicates whether we are on the testnet or not.

Closes https://github.com/ethcore/parity/issues/3522

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Nov 18, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 85.971% when pulling 1686d23 on jg-signer-api-queries into 51012d1 on master.

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 18, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 85.965% when pulling 4498fd5 on jg-signer-api-queries into 51012d1 on master.

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. A0-pleasereview 🤓 Pull request needs code review. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 21, 2016
@ngotchac
Copy link
Contributor

Might want to change src/dapps/basiccoin/services.js L108 and src/redux/providers/statusReducer.js L34 from morden to testnet

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Nov 21, 2016
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 21, 2016
@ngotchac ngotchac merged commit 47f5a6d into master Nov 21, 2016
@ngotchac ngotchac deleted the jg-signer-api-queries branch November 21, 2016 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants