This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Don't query chain in Signer, use Redux isTest #3524
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functionality changed, but allows me to break up the Signer changes into smaller chunks.
This one (1 of n) gets rids of the uneeded queries for chain in the Signer. We have the information available on Redux, so no need to make extra queries for each component needing the information. As a bonus the
chain === 'testnet' || chain === 'morden'
change is now only done in one place in the UI, so it cleans up the codebase.In short: don't query for chain per component and pass it along the chain, use the global state that indicates whether we are on the testnet or not.
Closes https://github.com/ethcore/parity/issues/3522