Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Performance optimizations #353

Merged
merged 10 commits into from Feb 5, 2016
Merged

Performance optimizations #353

merged 10 commits into from Feb 5, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Feb 5, 2016

  • Got rid of node counters in state db by making account trie node keys unique. Each account trie data key is xored with account address before being passed to database.
    Note that makes it impossible to query random state data for PV63 :(
  • State snapshots with copy cache items on demand. Prevents full state copying on each call
  • Minor optimizations

block 955000:

$ du -h ~/.parity/*
476M    ~/.parity/906a34e69aec8c0d/blocks
155M    ~/.parity/906a34e69aec8c0d/extras
123M    ~/.parity/906a34e69aec8c0d/state
754M    ~/.parity/906a34e69aec8c0d

@arkpar arkpar added the A0-pleasereview 🤓 Pull request needs code review. label Feb 5, 2016
tomusdrw
tomusdrw reviewed Feb 5, 2016
View reviewed changes
ethcore/src/state.rs
@@ -92,8 +146,8 @@ impl State {
}

/// Mutate storage of account `a` so that it is `value` for `key`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a -> address

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 5, 2016
@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Feb 5, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 5, 2016
gavofyork pushed a commit that referenced this pull request Feb 5, 2016
Merge pull request #353 from ethcore/state
85e2ef1 
Performance optimizations
@gavofyork gavofyork merged commit 85e2ef1 into master Feb 5, 2016
@arkpar arkpar mentioned this pull request Feb 5, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arkpar @tomusdrw @gavofyork