Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fix flaky test #3547

Merged
merged 2 commits into from
Nov 21, 2016
Merged

Fix flaky test #3547

merged 2 commits into from
Nov 21, 2016

Conversation

keorn
Copy link

@keorn keorn commented Nov 21, 2016

and clean up chain specs.

@keorn keorn added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Nov 21, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 959ccc7 on fix-flaky-auth into ** on master**.

@rphmeier
Copy link
Contributor

rphmeier commented Nov 21, 2016

What does the rlp member mean for a generic-family engine?
(just a question about the changes to the spec file, tangential to the PR itself)

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 21, 2016
@keorn
Copy link
Author

keorn commented Nov 21, 2016

Its just the genesis block seal. So these just change the initial value of seal fields to 0.

@rphmeier
Copy link
Contributor

rphmeier commented Nov 21, 2016

interesting...why not use a JSON array and enforce the length to be equal to the field amount? seems a bit more flexible/tweakable than having to re-encode RLP to make changes

@keorn
Copy link
Author

keorn commented Nov 21, 2016

That's how it was.
I think it might be best to get rid of "fields" (redundant) and just have the RLP field which has to be a valid list (then it is compatible with whatever the seal generating function outputs, not requiring partial decoding). Also new seal type can be added if there is a new prominent Engine.

@gavofyork gavofyork merged commit 818e54d into master Nov 21, 2016
@gavofyork gavofyork deleted the fix-flaky-auth branch November 21, 2016 23:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants