Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Don't fetch balances on every new block if syncing #3591

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Conversation

ngotchac
Copy link
Contributor

Fixes #3582

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Nov 23, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 23, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 23, 2016

Should sort the the last remaining issues for https://github.com/ethcore/parity/issues/3544 when in disconnected/reconnected & syncing modes.

Will have to monitor for both syncing and normal operation once in. (Remaining optimisation PRs will also decrease number of queries, however this should be the last one for the cases where "it should not get queried now")

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. and removed A8-looksgood 🦄 Pull request is reviewed well. A0-pleasereview 🤓 Pull request needs code review. labels Nov 23, 2016
@gavofyork gavofyork merged commit 0501658 into master Nov 23, 2016
@gavofyork gavofyork deleted the ng-sync-ws branch November 23, 2016 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants