Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Signer layouts to flexbox #3600

Merged
merged 4 commits into from
Nov 25, 2016
Merged

Signer layouts to flexbox #3600

merged 4 commits into from
Nov 25, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Nov 24, 2016

Simplifies the Signer layouts by moving the column display to flexbox, while also removing visual glitches between components.

Before -

parity 2016-11-24 14-48-12
parity 2016-11-24 14-42-41

With this -

https://www.youtube.com/watch?v=YbNmOQTlCrk

(Not 100% where it should be yet since there is still duplication in classes between components, however allows us to move ahead with the adaptions with the signer info that is in the queue.)

# Conflicts:
#
js/src/views/Signer/components/TransactionFinished/TransactionFinished.c
ss
@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Nov 24, 2016
@ngotchac
Copy link
Contributor

Looks good but there is(are) still scroll bar(s) on the embedded Signer on my side. Would be nice to get rid of them.

Something like this works for me:

diff --git a/js/src/views/ParityBar/parityBar.css b/js/src/views/ParityBar/parityBar.css
index 49275bc..5b01613 100644
--- a/js/src/views/ParityBar/parityBar.css
+++ b/js/src/views/ParityBar/parityBar.css
@@ -43,7 +43,7 @@
 
 .expanded {
   right: 16px;
-  height: 300px;
+  max-height: 300px;
   border-radius: 4px 4px 0 0;
   overflow-y: auto;
   display: flex;
diff --git a/js/src/views/Signer/components/TransactionPending/TransactionPending.css b/js/src/views/Signer/components/TransactionPending/TransactionPending.css
index 44d3145..5cd2d10 100644
--- a/js/src/views/Signer/components/TransactionPending/TransactionPending.css
+++ b/js/src/views/Signer/components/TransactionPending/TransactionPending.css
@@ -23,6 +23,5 @@
 
   & > * {
     vertical-align: middle;
-    min-height: $pendingHeight;
   }
 }

@ngotchac ngotchac added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 25, 2016
@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Nov 25, 2016
@ngotchac
Copy link
Contributor

@jacogr Pushed changes. Can you confirm didn't introduced issues?

@jacogr jacogr merged commit e95ef01 into master Nov 25, 2016
@jacogr jacogr deleted the jg-signer-styling branch November 25, 2016 16:20
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 4876e23 on jg-signer-styling into ** on master**.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants