This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Smarter balance fetching #3605
Merged
Smarter balance fetching #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Nov 25, 2016
| @@ -51,15 +51,30 @@ export function inHash (hash) { | |||
| return inHex(hash); | |||
| } | |||
|
|
|||
| export function pad (input, length) { | |||
| export function padRight (input, length) { | |||
There was a problem hiding this comment.
Move to /api/util/format.js? (pad{left,Right})
jacogr
reviewed
Nov 25, 2016
| // Fetch all tokens every 2 minutes | ||
| this.throttledTokensFetch = throttle( | ||
| this.fetchTokens, | ||
| 2 * 60 * 1000, |
jacogr
reviewed
Nov 25, 2016
| format: format.toString(), | ||
| id: tokenId, | ||
| image: hashToImageUrl(image), | ||
|
|
jacogr
reviewed
Nov 25, 2016
|
|
||
| const initialState = { | ||
| balances: {}, | ||
| tokens: {} | ||
| tokens: {}, | ||
|
|
jacogr
reviewed
Nov 25, 2016
| } | ||
|
|
||
| const balance = Object.assign({}, balances[address]); | ||
|
|
There was a problem hiding this comment.
extra blank (and 2 down as well, doesn't add much in terms of readability)
jacogr
reviewed
Nov 25, 2016
| } | ||
|
|
||
| if (this._manifests[manifestHash]) { | ||
| return this._manifests[manifestHash]; |
|
@jacogr Should be ok now :) |
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3590
This might also (hopefully) close #3240
Fetching balances is done smarter, in several ways:
It is likely that every token used will implement the correct Transfer event. Some implementations might differ, or for example when buying some GavCoin (tokens created). Thus all the balances are fetched every 2 minutes, just to be sure.