Manually add \r to Windows phrases pre 1.4.5 #3615
Conversation
jacogr
changed the title
| if (createType === 'fromPhrase' && windowsPhrase) { | ||
| phrase = phrase | ||
| .split(' ') // get the words | ||
| .map((w) => ['zoom', 'misjudged'].includes(w) ? w : `${w}\r`) // add \r after each (except last in dicts) |
There was a problem hiding this comment.
So I guess we see two words here because one is coming from 1.4 dict, and the second one is in 1.5 dict.
- We need to check if that's actually the case (that there is no new line character after last word)
- The word from 1.4 dict cannot be present in 1.5 dict for this code to work.
I think it would be better to only support 1.4 (so only one word), master branch is known to be unstable, and we should just mention that in the release notes instead.
There was a problem hiding this comment.
Updated to only support misjudged as per https://github.com/ethcore/parity/blob/v1.4.4/ethstore/res/wordlist.txt
|
Would be good to test it on windows (especially the |
|
Looks good. Would be great to test on windows, as @tomusdrw said. |
ngotchac
added
A8-looksgood 🦄
|
If I created the wallet in linux; and try to import it's recorvery phrase in windows, this wouldn't make a new issue? Edit: checked the source and saw that a checkbox was added for informing that. |
Fixes https://github.com/ethcore/parity/issues/3613 (Original report https://github.com/ethcore/parity/issues/3584)
@tomusdrw Please take a peek