Use accountsInfo instead of eth_accounts for first check #3618
Conversation
| } | ||
|
|
||
| _checkAccounts () { | ||
| this._api.parity |
There was a problem hiding this comment.
Do we really need to make this call each time the app if started ? I guess if showFirstRun is set to 0 in LS, we shouldn't need to display this modal even if I deleted all my accounts.
Plus, if this.firstrunVisisble is true, this call is useless.
Lastly, can't we tweak the window to skip the account creation if the user already have some created accounts ?
There was a problem hiding this comment.
We actually have the above actually logged as an enhancement, https://github.com/ethcore/parity/issues/3583. (Won't get in with 1.5 though)
Didn't try to re-invent the world, just tried to take what we have and change the call - already did more than needed with the move to a store to clean up a little bit. (With the eth_account changes it will show up each and every time, so this is needed before that change lands)
ngotchac
added
A6-mustntgrumble 💦
ngotchac
added
A8-looksgood 🦄
|
no js build on the ci? |
Prepares for https://github.com/ethcore/parity/issues/2285