This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Dapps-specific accounts #3627
Merged
Dapps-specific accounts #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 23, 2016 16:27
Conflicts: Cargo.lock
Conflicts: Cargo.lock rpc/src/v1/tests/mocked/parity_accounts.rs
tomusdrw
added
A0-pleasereview 🤓
|
Changes Unknown when pulling f5a8996 on rpc-middleware into ** on master**. |
|
can we get an issue for point 1 and mark |
gavofyork
reviewed
Nov 29, 2016
| @@ -266,7 +266,7 @@ impl Server { | |||
| #[cfg(test)] | |||
| /// Returns address that this server is bound to. | |||
| pub fn addr(&self) -> &SocketAddr { | |||
| self.server.as_ref().expect("server is always Some at the start; it's consumed only when object is dropped; qed").addr() | |||
| &self.server.as_ref().expect("server is always Some at the start; it's consumed only when object is dropped; qed").addrs()[0] | |||
There was a problem hiding this comment.
panicker: prove or remove!
what guarantee is that that there is at least one address in addrs? in any case better to use .front() to make this explicit.
There was a problem hiding this comment.
It's a test-only code, but proof added.
gavofyork
added
A6-mustntgrumble 💦
tomusdrw
added
A0-pleasereview 🤓
|
Changes Unknown when pulling df3c07b on rpc-middleware into ** on master**. |
gavofyork
added
A7-looksgoodcantmerge 🙄
gavofyork
added
A8-looksgood 🦄
tomusdrw
added
the
B7-releasenotes 📜
gavofyork
removed
the
B7-releasenotes 📜
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial take on #3382
Refererheader (it can be spoofed though, we need to figure out something better)DappIdparameter is added toeth_accountsvia Middleware (I have a much better approach in mind, but need to significantly rewritejsonrpc-corefor that, will follow in next PRs)jsonrpcpackages fromethcore/jsonrpcwith updatedhyperandrotor/mio/slab, should solve Parity 1.4.4 panics with "Tried to insert into filled index" Error #3545 too.