This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Blocks propagation #364
Merged
Blocks propagation #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
|
clients that are too far behind should not be tried to be updated |
| _ => lagging_peers.iter().filter(|_| ::rand::random::<u8>() < 64u8).cloned().collect::<Vec<(usize, H256)>>() | ||
| }; | ||
|
|
||
| match lucky_peers.len() { |
There was a problem hiding this comment.
could be just lucky_peers.resize(min(MIN_PEERS_PROPAGATION, lucky_peers.len())) or lucky_peers.drain(...)
NikVolf
added
A0-pleasereview 🤓
| } | ||
|
|
||
| fn create_latest_block_rlp(chain: &BlockChainClient) -> Bytes { | ||
| chain.block(&chain.chain_info().best_block_hash).unwrap() |
There was a problem hiding this comment.
Error should be handled here
arkpar
added
A4-gotissues 💥
| trace!(target: "sync", "Sent new hashes to peers: {:?}", peers); | ||
| } | ||
|
|
||
| pub fn chain_blocks_verified(&mut self, io: &mut SyncIo) { |
|
would like to see a little bit of documentation on the private functions |
gavofyork
added
A6-mustntgrumble 💦
NikVolf
added
A0-pleasereview 🤓
Conflicts: util/src/journaldb.rs
NikVolf
added
A4-gotissues 💥
|
ah when writing tests in other branch discovered that packet for all propagades should contain difficulty as well
|
NikVolf
added
A0-pleasereview 🤓
| @@ -38,6 +38,8 @@ pub struct BlockQueueInfo { | |||
| pub verified_queue_size: usize, | |||
| /// Number of blocks being verified | |||
| pub verifying_queue_size: usize, | |||
| /// Indicates queue is empty | |||
| pub empty: bool | |||
There was a problem hiding this comment.
is this really a necessary optimisation? (why not fn empty(&self) -> bool { verification.verified.is_empty() && verification.unverified.is_empty() && verification.verifying.is_empty() }?
There was a problem hiding this comment.
function for BlockQueueInfo?
seems reasonable
I guess 'full' should be function as well then, right?
arkpar
added
A8-looksgood 🦄
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sends new known hashes to peers that probably have not got em