Update Webpack => v2 #3643
Update Webpack => v2 #3643
Conversation
| "build:app": "webpack --progress", | ||
| "build:lib": "webpack --config webpack.libraries --progress", | ||
| "build:dll": "webpack --config webpack.vendor --progress", | ||
| "build:app": "webpack --config webpack/config --progress", |
There was a problem hiding this comment.
Could we maybe rename the config now? Each are config files, we can call this one app (or something similar)
| <Provider store={ store }> | ||
| <Container /> | ||
| </Provider> | ||
| <Provider store={ store }> |
There was a problem hiding this comment.
Glad this got fixed in eslint, was driving me up the wall.
| @@ -22,7 +22,10 @@ import IconButton from 'material-ui/IconButton'; | |||
| import AddIcon from 'material-ui/svg-icons/content/add'; | |||
| import RemoveIcon from 'material-ui/svg-icons/content/remove'; | |||
|
|
|||
| import { Input, InputAddressSelect, Select } from '../../../ui'; | |||
| import Input from '../../../ui/Form/Input'; | |||
There was a problem hiding this comment.
Ahhh, circular detection. Good.
There was a problem hiding this comment.
Still one in src/api/contract.js importing Api to check that the given api in constructor is an instance of Api class, and src/api/api.js importing Contract used in the newContract method...
There was a problem hiding this comment.
We could just change that one in contract.js to an existence check for the api & abi. (There are no places where we encourage direct use)
|
Merge conflicts. |
|
Changes Unknown when pulling d78de18 on ng-webpack-update into ** on master**. |
This PR is a first WIP for updating UI JS dependencies.
It should fix #3520 as the default saved version of a new installed package begins with
~(which fixes the version, updating only for patches) instead of the more general^.Webpack is updated to v2, with a working Hot Reload. Eslint is also updated.
This will make updating React and Material UI easier.