Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

show snackbar on password change #3661

Merged
merged 2 commits into from
Nov 28, 2016
Merged

show snackbar on password change #3661

merged 2 commits into from
Nov 28, 2016

Conversation

derhuerst
Copy link
Contributor

@derhuerst derhuerst commented Nov 28, 2016

Fixes #3595.

This PR makes the snack bar show up with the message that has previously been visible in the modal. The modal gets closed.

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Nov 28, 2016
};

this.setState({ waiting: false, message, showMessage: true });
showSnackbar(<div>Your password has been changed successfully.</div>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to swap the last 2 words around.

@gavofyork gavofyork added A0-pleasereview 🤓 Pull request needs code review. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 28, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 28, 2016
@jacogr jacogr merged commit 65f4ba8 into master Nov 28, 2016
@jacogr jacogr deleted the jr-password-close-modal branch November 28, 2016 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Password manager should close once password changed.
3 participants