This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Safari UI fixes #3678
Merged
Safari UI fixes #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Nov 29, 2016
•
jacogr
commented
- Minimum height for signer overlay, Fixes https://github.com/ethcore/parity/issues/3675
- onTouchTap for TabBar clicks, Fixes https://github.com/ethcore/parity/issues/3676
gavofyork
added
A8-looksgood 🦄
ngotchac
added
A5-grumble 🔥
|
This breaks layout in Chrome (adds an unnecessary vertical scroll bar). Don't have Safari to test though |
ngotchac
suggested changes
Nov 29, 2016
| @@ -55,6 +55,7 @@ | |||
| overflow: auto; | |||
| display: flex; | |||
| background: rgba(0, 0, 0, 0.8); | |||
| min-height: 300px; | |||
There was a problem hiding this comment.
This should be min-height = .expanded.max-height (300) - (.header.height + 2*.header.padding), thus around 248px
There was a problem hiding this comment.
Think it is actually because we have 2 min-heights in there somewhere. (pending container as well)
There was a problem hiding this comment.
Ok, got my macOS scrollbars to always show, one only on Chrome & Safari.
jacogr
added
A0-pleasereview 🤓
ngotchac
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.