Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

button to print recovery phrase #3694

Merged
merged 4 commits into from
Dec 1, 2016
Merged

button to print recovery phrase #3694

merged 4 commits into from
Dec 1, 2016

Conversation

derhuerst
Copy link
Contributor

Fixes #3588.

modal

recovery

Will add the Parity logo.

@derhuerst derhuerst added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Nov 30, 2016
@derhuerst
Copy link
Contributor Author

recovery2

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Nov 30, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Nov 30, 2016
@jacogr
Copy link
Contributor

jacogr commented Nov 30, 2016

  • FF has the URL at top right (slightly different from what shown), but otherwise ok, looks good
  • Would have added the print button to the modal buttonbar for the sake of uniformity (actions on the bottom in modals everywhere - bear in mid this affects 2 modals), but functional otherwise

@jacogr jacogr added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Nov 30, 2016
@gavofyork gavofyork merged commit 6420ea4 into master Dec 1, 2016
@gavofyork gavofyork deleted the jr-print-recovery-phrase branch December 1, 2016 01:11
@derhuerst
Copy link
Contributor Author

FF has the URL at top right (slightly different from what shown)

That sounds a lot like the printing option that you can turn off in every browsers printing dialog. We don't have control over that afaik.

Would have added the print button to the modal buttonbar for the sake of uniformity

you're right. will make a follow-up PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants