Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

move recovery phrase print button #3697

Merged
merged 4 commits into from Dec 2, 2016
Merged

move recovery phrase print button #3697

merged 4 commits into from Dec 2, 2016

Conversation

derhuerst
Copy link
Contributor

Follow-up of #3694.

@derhuerst derhuerst added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M7-ui labels Dec 1, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 6822433 on jr-move-recovery-print into ** on master**.

@jacogr jacogr added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. and removed A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). labels Dec 1, 2016
@jacogr
Copy link
Contributor

jacogr commented Dec 1, 2016

Needs to be on the FirstRun modal as well.

@@ -179,12 +185,18 @@ export default class CreateAccount extends Component {
];

case 2:
return (
return [
createType === 'fromNew' ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also for fromPhrase

@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. and removed A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Dec 1, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 1, 2016
@gavofyork gavofyork merged commit 5b829ae into master Dec 2, 2016
@gavofyork gavofyork deleted the jr-move-recovery-print branch December 2, 2016 03:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants