Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

kcov uses travis_job_id instead of coveralls token #370

Merged
merged 2 commits into from Feb 8, 2016
Merged

Conversation

debris
Copy link
Collaborator

@debris debris commented Feb 8, 2016

it should fix coverage reports

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Feb 8, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 8, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Feb 8, 2016

why there is no CI checks on this one?

@NikVolf NikVolf added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Feb 8, 2016
@debris
Copy link
Collaborator Author

debris commented Feb 8, 2016

No idea. Looks like travis.org is not working properly again...

@debris
Copy link
Collaborator Author

debris commented Feb 8, 2016

according to https://travis-ci.org/ethcore/parity/requests job was accepted. Don't know why build hasn't started

@NikVolf
Copy link
Contributor

NikVolf commented Feb 8, 2016

"branch not included or excluded" there

@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Feb 8, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 8, 2016
@NikVolf
Copy link
Contributor

NikVolf commented Feb 8, 2016

we should have stayed on travis-pro :)

gavofyork pushed a commit that referenced this pull request Feb 8, 2016
kcov uses travis_job_id instead of coveralls token
@gavofyork gavofyork merged commit 35902cb into master Feb 8, 2016
@debris debris deleted the travis_job_id branch February 8, 2016 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants