First draft of the MultiSig Wallet #3700
Conversation
ngotchac
added
A3-inprogress ⏳
|
Changes Unknown when pulling 83d4d8a on ng-mutisig-wallet into ** on master**. |
| padding: 0.75em 0.5em 0; | ||
|
|
||
| > * { | ||
| // height: 32px; |
ngotchac
added
A0-pleasereview 🤓
|
(for a separate PR) would be good to have a secondary wallet option of https://github.com/ethcore/contracts/blob/master/BasicWallet.sol |
|
@gavofyork Yes, we talked about this with @jacogr ; it will be available |
|
@ngotchac As discussed, functionality-wise there are some gaps (e.g. existing contract attachment, simple parameters, editing of options) and there are some UX nigglies along the way (layout inconsistencies, information better placed elsewhere). All these we chatted about. However since we already trimmed this one down far as possible, it probably wouldn't make sense to get that in since it makes it un-reviewable again. So my suggestion is to get it in in the current form, which will also allow for some wider functionality review. Will just triage with you again on my list of items and compare against yours so I don't log things unnecessarily. |
|
@jacogr mark looks good, then? |
|
functionality-wise, it's pretty sound. |
jacogr
added
A8-looksgood 🦄
Would hopefully close #3282 for now...
This is a first draft and a WIP for support of multi-signatures wallets (attaching existing ones and creating new ones)....