This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Use fdlimit utility crate from crates.io #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
|
appveyor fail seems unrelated |
|
Link to repository/docs on the crates.io page would be appreciated -- where is this code stored now? |
|
Changes Unknown when pulling 42fc770 on fdlimit into ** on master**. |
|
https://github.com/ethcore/fdlimit thought cargo will put it automatically sorry |
rphmeier
added
A8-looksgood 🦄
|
LGTM but maybe it's worth bumping the version on crates.io so we can update the manifest fields before merging |
|
Changes Unknown when pulling ebd4173 on fdlimit into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.