This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Properly delete addresses/contracts in addressbook #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Dec 7, 2016
•
jacogr
commented
- Convert previously marked meta.deleted entries into deleted
- Use parity_removeAddress to delete addresses (instead of marking)
- Remove now unneeded meta.deleted checks
|
Changes Unknown when pulling cebfef2 on jg-address-delete into ** on master**. |
derhuerst
reviewed
Dec 8, 2016
| }) | ||
| .catch((error) => { | ||
| console.warn('removeDeleted', error); | ||
| return []; |
There was a problem hiding this comment.
Returning [] is unnecessary afaict.
derhuerst
added
A7-looksgoodcantmerge 🙄
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.