Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

jsonrpc #374

Merged
merged 15 commits into from Feb 9, 2016
Merged

jsonrpc #374

merged 15 commits into from Feb 9, 2016

Conversation

debris
Copy link
Collaborator

@debris debris commented Feb 8, 2016

  • implemented few more jsonrpc methods
  • jsonrpc serialization tests
  • added transaction querying api to blockchain.rs

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Feb 8, 2016
@debris debris changed the title jsonrpc [in progress] jsonrpc Feb 8, 2016
@gavofyork
Copy link
Contributor

this changes the database format (inserts additional stuff into extras db). did you alter the DB format to force re-sync?

@debris
Copy link
Collaborator Author

debris commented Feb 8, 2016

how to force re-sync?

@gavofyork
Copy link
Contributor

@arkpar added the database versioning a few commits ago...

@debris
Copy link
Collaborator Author

debris commented Feb 9, 2016

re-sync forced

arkpar
arkpar reviewed Feb 9, 2016
View reviewed changes
util/src/journaldb.rs
@@ -50,7 +50,7 @@ impl Clone for JournalDB {
const LAST_ERA_KEY : [u8; 4] = [ b'l', b'a', b's', b't' ];
const VERSION_KEY : [u8; 4] = [ b'j', b'v', b'e', b'r' ];

const DB_VERSION: u32 = 1;
const DB_VERSION: u32 = 2;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the state db version. You need to change CLIENT_DB_VER_STR in client.rs instead

@arkpar arkpar added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 9, 2016
@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Feb 9, 2016
@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Feb 9, 2016
NikVolf added a commit that referenced this pull request Feb 9, 2016
@NikVolf
Merge pull request #374 from ethcore/jsonrpc
97789cb 
jsonrpc
@NikVolf NikVolf merged commit 97789cb into master Feb 9, 2016
@debris debris deleted the jsonrpc branch February 10, 2016 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@debris @gavofyork @arkpar @NikVolf