This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Edit Multisig Wallet settings #3740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A0-pleasereview 🤓
jacogr
reviewed
Dec 8, 2016
| @@ -113,7 +113,7 @@ export function inNumber10 (number) { | |||
|
|
|||
| export function inNumber16 (number) { | |||
| if (isInstanceOf(number, BigNumber)) { | |||
| return inHex(number.toString(16)); | |||
| return inHex(number.round().toString(16)); | |||
There was a problem hiding this comment.
This is dangerous to do in the API, since the user needs to specify the correct values. When it is not a valid int, we should actually throw an exception - needs to be handled properly where called from.
What I do agree, currently we try to format invalid values, needs to stop doing that - but the inputs needs to be supplied properly. So throw & get app developer to fix.
jacogr
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds to the Wallet the capability to edit the settings (owners, require, dailylimit).
It also fixes a fex bugs, and use the optimized bytecodes version which lower the gas amount at creation from 2.3M to 1.7M
In order to edit the settings, there is no way that we could show the pending operations to the users since it is not possible from the current contract version to link an operation hash to an actual operation. One idea would be to edit the contract and add to the
Pendingstruct adatafield which would hold themsg.databytes. Then add a getter from an operationhash. This will make it possible to know which method was called for every pending operations, but only for new contracts versions. For older ones, we'll just have to tell users to ask all required owners to edit the same settings to take them into account...