This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
GasEditor component #3750
Merged
GasEditor component #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derhuerst
reviewed
Dec 8, 2016
| @observable errorEstimated = null; | ||
| @observable errorGas = null; | ||
| @observable errorPrice = null; | ||
| @observable estimated = DEFAULT_GAS; |
There was a problem hiding this comment.
Now that the gas price calculations are fully externalised, I'd prefer to have numbers here, not strings. Same for setGas and setPrice.
There was a problem hiding this comment.
Feel free to log an issue if it is critical and put it in the queue. It is not hapenning in this PR. Bear in mind -
- Everything BigNumbers at the very least
- Data coming from inputs are strings as it stands, with a mixture coming in via BigNumber (typically RPC BN -> input text -> BN -> ? would need to be done)
- Impact on other stores (eg. Transfer that expects things in certain formats)
derhuerst
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes https://github.com/ethcore/parity/issues/3510 & https://github.com/ethcore/parity/issues/2605 possible