This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Replace misplaced & with && in gitlab-ci.yml #3753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
arkpar
reviewed
Dec 9, 2016
| @@ -422,13 +422,14 @@ test-rust-stable: | |||
| image: ethcore/rust:stable | |||
| before_script: | |||
| - git submodule update --init --recursive | |||
| - export RUST_FILES_MODIFIED=$(git --no-pager diff --name-only $CI_BUILD_REF^ $CI_BUILD_REF | grep \.rs | wc -l) | |||
There was a problem hiding this comment.
There a few other extensions that need to trigger rust tests. e.g. .json, .toml.
Better just check if any of the non-js files have been modified with something like grep -v \.js instead of grep -j \.rs
|
is it really true that any file which does not end in |
gavofyork
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. rust-test is running JS things here - https://gitlab.ethcore.io/Mirrors/ethcore-parity/builds/30044