This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Tendermint Engine #3759
Merged
Tendermint Engine #3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: ethcore/src/error.rs
Conflicts: ethcore/src/client/client.rs
keorn
added
A0-pleasereview 🤓
|
Changes Unknown when pulling fa504e5 on auth-bft into ** on master**. |
|
Changes Unknown when pulling 49ae375 on auth-bft into ** on master**. |
NikVolf
reviewed
Dec 13, 2016
|
|
||
| pub fn new_proposal(header: &Header) -> Result<Self, ::rlp::DecoderError> { | ||
| Ok(ConsensusMessage { | ||
| signature: try!(UntrustedRlp::new(header.seal()[1].as_slice()).as_val()), |
There was a problem hiding this comment.
would be nice to use get(1).expect("<reason why it cannot fail>") here also
NikVolf
reviewed
Dec 13, 2016
| 0u8 => Ok(Step::Propose), | ||
| 1 => Ok(Step::Prevote), | ||
| 2 => Ok(Step::Precommit), | ||
| _ => Err(DecoderError::Custom("Invalid step.")), |
There was a problem hiding this comment.
No Step::Commit variant here? Is it not supposed to ever come in the RLP form?
There was a problem hiding this comment.
Yep, there is no meaning to RLP encoded Commit - its a collection of encoded Precommits.
|
Changes Unknown when pulling c96826b on auth-bft into ** on master**. |
gavofyork
added
A9-FUCKYEAH!1 💯
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New asynchronous BFT consensus
Enginewith instant finality.To do:
TransitionHandlershutdownsyncproposal broadcastTendermintNew
parprotocol version (2) is added, which supports sending consensus messages to peers.Tenderminthandles messages and issues new ones. Each round starts with a proposal block issued by one of the authorities and is broadcasted like a normal block. After verification each block is checked withEngineto check if its a proposal or a normal block that should be inserted into the blockchain. Once one round reaches enoughPrecommits, the block is issued sealed with a signature set which makes it possible to verify the block without referring back to the messages.