This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
email verification #3766
Merged
email verification #3766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modal got really crowded and the preparation step had only been shown for fractions of a second anyways. The "loading" message is now part of the next step.
|
Changes Unknown when pulling a94bbea on jr-email-verification into ** on master**. |
jacogr
reviewed
Dec 9, 2016
| // You should have received a copy of the GNU General Public License | ||
| // along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| import { stringify } from 'querystring'; |
There was a problem hiding this comment.
I would suggest at least breaking this out into -
- React-specific (useless for libraries)
- Verification/use specific
jacogr
reviewed
Dec 9, 2016
| /* along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| .list li { |
There was a problem hiding this comment.
As above, from a library perspective styles here are a no-no. It is up to the display to determine how it should look.
jacogr
reviewed
Dec 9, 2016
| @@ -17,6 +17,19 @@ | |||
| import { stringify } from 'querystring'; | |||
| import React from 'react'; | |||
|
|
|||
| import styles from './styles.css'; | |||
jacogr
reviewed
Dec 9, 2016
| return smsVerification; | ||
| return verification; | ||
| } | ||
| get emailVerification () { |
There was a problem hiding this comment.
Extra space here between the 2 would be appreciated.
jacogr
reviewed
Dec 9, 2016
| @@ -25,41 +25,31 @@ import { fromWei } from '~/api/util/wei'; | |||
| import { Form, Input } from '~/ui'; | |||
| import { nullableProptype } from '~/util/proptypes'; | |||
|
|
|||
| import { termsOfService } from '../../../3rdparty/sms-verification'; | |||
| import * as sms from '../../../3rdparty/sms-verification'; | |||
There was a problem hiding this comment.
Use ~/3rdparty/... rather so we don't need to clean it up later
We might want to bundle the code in `3rdparty`. React & presentational components don't belong in there. At the same time, the terms of service are strictly related to the use of these external services. We decided to not bundle them, but still keep them in a file called `terms-of-service.js`. The commit also moves the "how it works" section into the presentational part in `modals/Verification`.
jacogr
added
A4-gotissues 💥
|
Tests failing on build. |
|
Changes Unknown when pulling c439445 on jr-email-verification into ** on master**. |
jacogr
reviewed
Dec 13, 2016
| const methods = { | ||
| sms: { | ||
| label: 'SMS Verification', key: 0, value: 'sms', | ||
| description: (<p className={ styles.noSpacing }>It will be stored on the blockchain that you control a phone number (not <em>which</em>).</p>) |
There was a problem hiding this comment.
Not a crisis for this PR since this one straddled the boundary between merges, but going forward when touching components change the text into FormattedMessages.
jacogr
removed
the
A4-gotissues 💥
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds another verification method:
The process is integrated into the verification modal. In the beginning, the user choses a verification method. @tjsaw is working on the terms of service.
When the verification is done, a contract compatible with
Certifier.solwill store the hash of the email address.I tried to reuse as much of the code in
modals/Verification/store.jsas possible, although that makes it a bit harder to understand. I'm also not a fan of the inheritance used bysms-store.jsandemail-store.js. I'm open for proposals.