Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

GasPrice selection for contract execution #3770

Merged
merged 2 commits into from
Dec 9, 2016
Merged

GasPrice selection for contract execution #3770

merged 2 commits into from
Dec 9, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 9, 2016

Closes https://github.com/ethcore/parity/issues/3510

https://youtu.be/zT0ioLLxuA0

(Modal states should really be converted to MobX stores like @ngotchac has done with Transfer, much cleaner to maintain)

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 9, 2016
@ngotchac
Copy link
Contributor

ngotchac commented Dec 9, 2016

It looks good, but still misses some places for gas price selection (at least contract deployment). As discussed, I would rather have this available (as well) in the Signer view/overlay.

As a side note, I think modals should be refactor, as it shouldn't be that compilcated to manage modal step, create new ones, etc... But this is just a side note ;)

@jacogr
Copy link
Contributor Author

jacogr commented Dec 9, 2016

Signer is currently WIP as per https://github.com/ethcore/parity/issues/3016 & https://github.com/ethcore/parity/issues/2605

First step was getting the component out, second to make sure it works as expected in another use (here), then signer - which has got additional complexities.

@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 9, 2016
@gavofyork gavofyork merged commit 598fd42 into master Dec 9, 2016
@gavofyork gavofyork deleted the jg-execute-gas branch December 9, 2016 19:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants