This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Lower gas usage for creating a Multisig Wallet #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should be doing the library deploys using the Parity keys. So when you are happy, let me know and I can deploy & register using the required keys. I'm assuming there is no issues across multiple networks, e.g. Ropsten & Homestead from a UI & knowing where to find stuff perspective? (Doesn't look like there is, just confirming.) |
jacogr
reviewed
Dec 9, 2016
| import { ERROR_CODES } from '~/api/transport/error'; | ||
| import { wallet as walletAbi } from '~/contracts/abi'; | ||
| import { wallet as walletCode } from '~/contracts/code'; | ||
| import { walletLibraryRegKey, fullWalletCode } from '~/contracts/code/wallet'; |
There was a problem hiding this comment.
We cannot combine this import with the previous one?
|
Okay sure. I registered it on Ropsten, so you can test. When everything is fine, I'll transfer the ownership of the registered key on Ropsten. |
jacogr
added
A8-looksgood 🦄
|
there's ethcore/contracts repo for any contract stuff we do... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new Multisig Wallet that only uses about 500k gas to deploy (compared to ~1.8 to 2M gas for the previous version).
This uses a Multisig Wallet Library that has to be deployed to the network (if not, it fallbacks to the old one).
One has been deployed to Ropsten already. To deploy a new one:
js/src/contracts/code/wallet.js[]is fine)js/src/contracts/code/wallet.js:walletLibraryFor new versions, when the Wallet is compiled, modify in the bytecode the references to
cafecafe...with__WalletLibrary___________The new contract is in
js/src/contracts/snippets/enhanced-wallet.sol