Add support for wallets without getOwner() interface #3779
Conversation
| @@ -89,7 +97,7 @@ export default class Registry { | |||
| return instance.getAddress.call({}, [sha3, 'A']); | |||
| }) | |||
| .then((address) => { | |||
| console.log('lookupAddress', name, sha3, address); | |||
| console.log('[lookupAddress]', `(${sha3.slice(0, 5)}...${sha3.slice(-3)}) ${name}: ${address}`); | |||
There was a problem hiding this comment.
Actually revert this (at least the slicing), this does get used in management via contract.
| @@ -112,31 +112,36 @@ export default class Input extends Component { | |||
| { this.renderCopyButton() } | |||
| <TextField | |||
| autoComplete='off' | |||
| name={ NAME_ID } | |||
There was a problem hiding this comment.
If you are re-formatting this, would really like it in alphabetical order so there is no confusion about what goes where. (Always make it alphabetical regardless of type or function, no mental overhead - as it is it makes sense to somebody, with your changes that somebody is you, keep it generic.)
| @@ -188,7 +188,7 @@ class TabBar extends Component { | |||
| return ( | |||
| <ToolbarGroup> | |||
| <div className={ styles.logo }> | |||
| <img src={ imagesEthcoreBlock } /> | |||
| <img src={ imagesEthcoreBlock } height={ 28 } /> | |||
There was a problem hiding this comment.
Any reason this is not in the css?
There was a problem hiding this comment.
Only because the CSS is loaded in JS, so there is a flash of ugly unstyled content on load. The logo was the thing that upset me the most.
With a bit more work, we should ship CSS files in production env anyway. This is just a quicker fix
| <Container title='events'> | ||
| <div> | ||
| <Loading | ||
| size={ 2 } |
There was a problem hiding this comment.
Single line is preferable here since it is only a single attribute.
| isTest={ isTest } | ||
| events={ allEvents } /> | ||
|
|
||
| <div> |
There was a problem hiding this comment.
Are the extra divs needed when the component itself is a div?
There was a problem hiding this comment.
Yes because the component has a background color set (black) and padding, which makes two components in a row merge without margins. Could replace padding with margin though, but need to make sure it doesn't break anything
jacogr
changed the title
jacogr
added
A5-grumble 🔥
ngotchac
added
A0-pleasereview 🤓
jacogr
added
A8-looksgood 🦄
This adds Mist Wallet support (which doesn't have the
getOwnermethod).Plus small fixes here and there (React errors from same keys for elements, stop fetching addresses from the registry twice if it is loading...)