Extract CSS to file in production builds #3783
Conversation
Excuse my ignorance - but if gets added automagically to the index.html file |
@jacogr Yep it does, as the JS files actually, thanks to |
Cool. Will just build with |
It seems to put the styles for everything in one, e.g. from There needs to be a split between the UI, dapps and between the dapps. Apart from that, seems to work as intended. |
Ah that's right, I'll look into that |
Ok this should be fixed now. Each dapp has it's own CSS file. Plus some files are now in subfolders: Also fixed |
@@ -82,28 +83,51 @@ module.exports = { | |||
] | |||
}, | |||
|
|||
// // Don't extract CSS for Dapps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still want this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
Merge in master to just run the checks. |
Export all the CSS to a proper file if built in production environment.
This prevents a flash of unstyled content on first load.
NB : this is not possible in dev mode since hot reloading doesn't play nice with external CSS files