Extended publishing of libraries to npm #3786
Conversation
jacogr
added
A3-inprogress ⏳
jacogr
added
A0-pleasereview 🤓
|
|
||
| Parity.js is a thin, fast, Promise-based wrapper around the Ethereum APIs. | ||
|
|
||
| [https://github.com/ethcore/parity/js/src/api](https://github.com/ethcore/parity/js/src/api) |
There was a problem hiding this comment.
This should be https://github.com/ethcore/parity/tree/master/js/src/api
|
|
||
| A thin, lightweight promise wrapper for the api.etherscan.io/apis service, exposing a common endpoint for use in JavaScript applications. | ||
|
|
||
| [https://github.com/ethcore/parity/js/src/3rdparty/etherscan](https://github.com/ethcore/parity/js/src/3rdparty/etherscan) |
There was a problem hiding this comment.
This should be https://github.com/ethcore/parity/tree/master/js/src/3rdparty/etherscan
Plus, don't we want to add the README there, so users can read it navigating to this URL ?
There was a problem hiding this comment.
Updated.
As for the README, do agree, but actually need to solve this with the source in npm issue as well. Will log and revisit.
| "bignumber.js": "^2.3.0", | ||
| "js-sha3": "^0.5.2", | ||
| "node-fetch": "^1.6.3" | ||
| "bignumber.js": "~2.3.0", |
There was a problem hiding this comment.
Why not using 2.3.0 directly? I'm sure the patches won't break anything, but we never know...
There was a problem hiding this comment.
It is actually bad form doing what we are doing. We should be using shinkwrap. (Extra step, but right approach)
|
|
||
| A thin ES6 promise wrapper around the shapeshift.io APIs as documented at https://shapeshift.io/api | ||
|
|
||
| [https://github.com/ethcore/parity/js/src/3rdparty/shapeshift](https://github.com/ethcore/parity/js/src/3rdparty/shapeshift) |
There was a problem hiding this comment.
https://github.com/ethcore/parity/tree/master/js/src/3rdparty/shapeshift + same comment on README as per etherscan
|
Changes Unknown when pulling b422714 on jg-library-builds into ** on master**. |
|
I added some tests to the published libraries. For I added a call to If this is useless, feel free to revert my commits ( |
|
Changes Unknown when pulling 861280b on jg-library-builds into ** on master**. |
jacogr
added
A8-looksgood 🦄
Publish all external libraries now,
parity.js,etherscan&shapeshiftintegrations