Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixes to the Wallet UI #3787

Merged
merged 3 commits into from
Dec 10, 2016
Merged

Fixes to the Wallet UI #3787

merged 3 commits into from
Dec 10, 2016

Conversation

ngotchac
Copy link
Contributor

@ngotchac ngotchac commented Dec 9, 2016

gavofyork [12:05 AM]  
number of "outgoing transactions" (i.e. nonce) is incorrect for contracts
they start at one (rather than zero for basic accounts).

it's particularly misleading for wallet contracts, since the actual outgoing transactions can be numerous even with a nonce of 1.
(nonce only gets increased for a contract account when it makes a `CREATE` operation) (edited)

also, wallet day limit of 0 makes little sense - if the daily limit (and do note, this is for single-signing shortcut - multi-signing is never limited) is zero, then it should just be elided from the UI (edited)

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 9, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 9, 2016
@jacogr jacogr merged commit b9c04fc into master Dec 10, 2016
@jacogr jacogr deleted the ng-wallet-fix branch December 10, 2016 00:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants