Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

eth_sign RPC now hashes given data instead of getting the hash #3800

Merged
merged 2 commits into from
Dec 12, 2016
Merged

eth_sign RPC now hashes given data instead of getting the hash #3800

merged 2 commits into from
Dec 12, 2016

Conversation

tomusdrw
Copy link
Collaborator

Closes #3297

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M6-rpcapi 📣 RPC API. labels Dec 10, 2016
@tomusdrw tomusdrw changed the title eth_sign RPC now hashes given data eth_sign RPC now hashes given data instead of getting the hash Dec 10, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 85.604% when pulling 9b5fd93 on eth-sign into a6fcd8a on master.

@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. B0-patch and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 12, 2016
@gavofyork gavofyork merged commit 2844a4e into master Dec 12, 2016
@gavofyork gavofyork deleted the eth-sign branch December 12, 2016 03:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. B7-releasenotes 📜 Changes should be mentioned in the release notes of the next minor version release. M6-rpcapi 📣 RPC API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomusdrw @coveralls @gavofyork