Network configuration for Ethereum Classic #3812
Conversation
|
Changes Unknown when pulling aed633d on ethereumproject:splix/classic-replay-protection into ** on ethcore:master**. |
rphmeier
added
A0-pleasereview 🤓
| "eip155Transition": "0x7fffffffffffffff", | ||
| "eip160Transition": "0x7fffffffffffffff", | ||
| "eip155Transition": 3000000, | ||
| "eip160Transition": 3000000, |
There was a problem hiding this comment.
decimal instead of hex numbers here?
There was a problem hiding this comment.
Hm, is that bad? because I see all new changes to configuration are using decimal for blocks
There was a problem hiding this comment.
just odd that it's inconsistent with the other transitions definition. I'd suggest to pick one and go with it (with the exception of those set to "0x7ffff..." since that's easiest to read as hex)
There was a problem hiding this comment.
Yes, it was unrelated to this commits, so I didn't touch it. But I prefer decimal of course, so as I can change other values, I'm go to do it right now
| @@ -25,7 +25,7 @@ | |||
| "accountStartNonce": "0x00", | |||
| "maximumExtraDataSize": "0x20", | |||
| "minGasLimit": "0x1388", | |||
| "networkID" : "0x1", | |||
| "networkID" : "0x3d", | |||
There was a problem hiding this comment.
Changing this will break connectivity with all peers on the old network. Just FYI
There was a problem hiding this comment.
Oh, I see. I misinterpreted this as a chainID. Thank you.
Where is CHAIN_ID option btw? I can't find it
There was a problem hiding this comment.
Currently there's no separate setting. This value is used for both network protocol id and EIP-155 transaction signing id
|
@arkpar I think I can add this CHAIN_ID configuration option. Unless you're already working on this feature. Is that ok? |
|
@splix Fine with me as long as it defaults to network_id if not specified. |
|
we don't really want to keep the "original" morden. do you guys really want to have a "morden classic"? you could just take "morden.json" itself. |
|
@gavofyork It's up to you actually. Yes, we can reuse existing morden, if no one uses it currently. I just see it uses ETH specific configuration for 1885k, so it's already incompatible. But there are only 1108 blocks after that fork, so probably nobody cares. |
|
Submitted with Morden config fixed for ETC |
|
@arkpar chain_id seems to be a different issue, I mean different PR |
|
Changes Unknown when pulling e61d14d on ethereumproject:splix/classic-replay-protection into ** on ethcore:master**. |
arkpar
added
A8-looksgood 🦄
gavofyork
added
the
B7-releasenotes 📜
EIP155, EIP160, Testnet