This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixed bool dropdown in contract execution #3823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jacogr
commented
Dec 12, 2016
jacogr
commented
- Fixes https://github.com/ethcore/parity/issues/3822
- Wrote breaking tests to replicate issue (and also added checks for TypedInput & DetailsStep for the same type)
derhuerst
reviewed
Dec 12, 2016
| { boolitems } | ||
| </Select> | ||
| ); | ||
| } | ||
|
|
||
| onChangeBool = (event, _index, value) => { | ||
| this.props.onChange(value === 'true'); | ||
| // NOTE: event.target.value added for enzyme simulated event testing |
There was a problem hiding this comment.
Not happy with this but i'm not sure there's a better solution.
There was a problem hiding this comment.
Can't we use the _index var ?
There was a problem hiding this comment.
@ngotchac Isn't it kind of fragile to depend on the order in the dropdown?
Thinking about e.target.value: It's actually spec-compatible, so I'm fine with it. Material UI actually adds the value parameter in a non-spec way.
There was a problem hiding this comment.
The ['false', 'true'] Array should be saved and used when creating the menu items and onChange IMO
derhuerst
added
A8-looksgood 🦄
|
Changes Unknown when pulling 3a7e30e on jg-typedinput-tests into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.