This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Using jsonrpc-macros #3831
Merged
Using jsonrpc-macros #3831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
debris
added
A8-looksgood 🦄
rphmeier
reviewed
Dec 13, 2016
| @@ -24,6 +24,8 @@ extern crate serde; | |||
| extern crate serde_json; | |||
| extern crate jsonrpc_core; | |||
| extern crate jsonrpc_http_server; | |||
| #[macro_use] | |||
| extern crate jsonrpc_macros; | |||
There was a problem hiding this comment.
I'd prefer to put this at the bottom with the other #[macro_use] crates.
|
Changes Unknown when pulling 65d62cc on rpc-macros into ** on master**. |
rphmeier
added
M4-core ⛓
|
(should be labeled core since it doesn't actually affect the public RPC API, just the implementation of it) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3789