Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Expand lint to catch css issues #3852

Merged
merged 2 commits into from
Dec 15, 2016
Merged

Expand lint to catch css issues #3852

merged 2 commits into from
Dec 15, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 15, 2016

No description provided.

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 15, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 85.565% when pulling 88a26ec on js-css-lint into 03db4d0 on master.

@derhuerst derhuerst added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 15, 2016
@derhuerst
Copy link
Contributor

It seems to be very permissive. This passes the check:

.noSpacing{
  margin-top: 0;
  margin-bottom: 0}.list li{
  padding: .1em 0;
}

@gavofyork gavofyork merged commit 1ebbb8a into master Dec 15, 2016
@gavofyork gavofyork deleted the js-css-lint branch December 15, 2016 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants