This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
require only simpler methods on Provider #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 4c7dc9f on single-provider-functions into ** on master**. |
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3846
Motivation:
The algorithm for stuff like getting block headers and serializing state proofs is relatively complex and should only really be done in one place. This one place could alternatively be in the
light::netmodule, but this would require more overhead when running in an IPC environment -- it's better to send the batch request over IPC and receive the batch response back.