This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
parity_chainStatus RPC for block gap info #3899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A3-inprogress ⏳
|
@rphmeier Updated with the JS interfaces (& tests). |
rphmeier
added
A0-pleasereview 🤓
keorn
added
A8-looksgood 🦄
|
Merge when ready (GitHub won't let me merge from a phone). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ethcore/parity/issues/3064
Takes out the
blockGapfield frometh_syncingas it was always null in practice and moves it into aparity_chainStatusRPC which can be used to query for the block gap (and potentially more in the future).cc @jacogr -- we should put the js side of things in this same PR.