Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixing Contract Development #3912

Merged
merged 11 commits into from Dec 20, 2016
Merged

Fixing Contract Development #3912

merged 11 commits into from Dec 20, 2016

Conversation

ngotchac
Copy link
Contributor

The contract development tool was in fact broken due to a bug in Chrome (seems to be fixed in v56).

This PR adds a fallback to Solidity compilation in the main thread (thus making the whole UI to freeze when compiling). It also removes the Worker which is replaced by a service worker. This will be used if possible, and will at least be used to cache Solidity versions so users don't need to be online once fetched once.

@ngotchac ngotchac added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Dec 20, 2016
@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 20, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling efb928b on ng-contract-dev into ** on master**.

@jacogr jacogr added A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 20, 2016
@jacogr
Copy link
Contributor

jacogr commented Dec 20, 2016

Compilation failure on CI -

ERROR in ./serviceWorker.js
    Module not found: Error: Can't resolve 'promise-worker/register' in '/builds/Mirrors/ethcore-parity/js/src'
     @ ./serviceWorker.js 17:0-60

@ngotchac ngotchac added A0-pleasereview 🤓 Pull request needs code review. and removed A4-gotissues 💥 Pull request is reviewed and has significant issues which must be addressed. labels Dec 20, 2016
@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 20, 2016
@jacogr
Copy link
Contributor

jacogr commented Dec 20, 2016

Looks good. Bit worried that we are not able to test on FF at this point to verify the other side (due to the connection issues). Chrome "freeze" is irritating, but it is what it is.

@gavofyork gavofyork merged commit 854cc60 into master Dec 20, 2016
@gavofyork gavofyork deleted the ng-contract-dev branch December 20, 2016 11:12
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7b3b82b on ng-contract-dev into ** on master**.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants