This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngotchac
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
M7-ui
labels
Dec 20, 2016
ngotchac
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Dec 20, 2016
Changes Unknown when pulling efb928b on ng-contract-dev into ** on master**. |
jacogr
added
A4-gotissues 💥
Pull request is reviewed and has significant issues which must be addressed.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Dec 20, 2016
Compilation failure on CI -
|
ngotchac
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A4-gotissues 💥
Pull request is reviewed and has significant issues which must be addressed.
labels
Dec 20, 2016
jacogr
added
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Dec 20, 2016
Looks good. Bit worried that we are not able to test on FF at this point to verify the other side (due to the connection issues). Chrome "freeze" is irritating, but it is what it is. |
Changes Unknown when pulling 7b3b82b on ng-contract-dev into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contract development tool was in fact broken due to a bug in Chrome (seems to be fixed in v56).
This PR adds a fallback to Solidity compilation in the main thread (thus making the whole UI to freeze when compiling). It also removes the Worker which is replaced by a service worker. This will be used if possible, and will at least be used to cache Solidity versions so users don't need to be online once fetched once.