This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Custom attribute for binary serialization #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
rphmeier
reviewed
Dec 20, 2016
| @@ -17,7 +17,7 @@ | |||
| extern crate ethcore_ipc_codegen; | |||
|
|
|||
| fn main() { | |||
| ethcore_ipc_codegen::derive_binary("src/types/mod.rs.in").unwrap(); | |||
| ethcore_ipc_codegen::derive_binary_cond("src/types/mod.rs.in", cfg!(feature="ipc")).unwrap(); | |||
There was a problem hiding this comment.
i don't 100% understand the use of adding the flag parameter here. having a function take a bool parameter saying whether it should run is pretty strange. I think it's also already covered with the cfg_attr guards that have been added everywhere.
There was a problem hiding this comment.
yeah forgot to remove it, originally it was just stripping attributes
rphmeier
added
A6-mustntgrumble 💦
|
Changes Unknown when pulling 29c1fee on binary-opt into ** on master**. |
NikVolf
added
A0-pleasereview 🤓
rphmeier
added
A8-looksgood 🦄
|
Changes Unknown when pulling 17ed223 on binary-opt into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because custom derives are going to become obsolete
Also makes binary serialization optional on feature