Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Store for EditMeta modal #3959

Merged
merged 3 commits into from
Dec 27, 2016
Merged

Store for EditMeta modal #3959

merged 3 commits into from
Dec 27, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 23, 2016

@jacogr jacogr added A0-pleasereview 🤓 Pull request needs code review. M7-ui labels Dec 23, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 85.536% when pulling d0223b3 on jg-edit-meta-store into 63d68aa on master.

derhuerst
derhuerst reviewed Dec 26, 2016
View reviewed changes
js/src/modals/EditMeta/store.js

transaction(() => {
this.name = name;
this.setNameError(nameError);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From reading the MobX rationale, I think this should be a @computed property.

@derhuerst derhuerst added A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 26, 2016
@gavofyork gavofyork merged commit 2bbefcd into master Dec 27, 2016
@gavofyork gavofyork deleted the jg-edit-meta-store branch December 27, 2016 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@derhuerst derhuerst derhuerst left review comments

Assignees
No one assigned
Labels
A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacogr @coveralls @derhuerst @gavofyork