Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Port try macro to new ? operator. #3962

Merged
merged 5 commits into from
Dec 27, 2016
Merged

Port try macro to new ? operator. #3962

merged 5 commits into from
Dec 27, 2016

Conversation

rphmeier
Copy link
Contributor

Using the untry tool. Some usages of try! are preserved within the codegen crate as quoted ? operators were being replaced with ) and producing broken generated code.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 23, 2016
@rphmeier
Copy link
Contributor Author

Note: inference with usages of collect()? into result are mildly broken due to the more general Carrier trait powering the operator. A brief type hint Result<_,_> is enough to correct the issue.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3ee8cb5 on untry into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3ee8cb5 on untry into ** on master**.

@gavofyork gavofyork added A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 27, 2016
@arkpar arkpar merged commit 8125b56 into master Dec 27, 2016
@arkpar arkpar deleted the untry branch December 27, 2016 11:54
@rphmeier rphmeier mentioned this pull request Jan 9, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rphmeier @coveralls @gavofyork @arkpar