Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

make test network generic over peer type #3974

Merged
merged 1 commit into from
Dec 28, 2016
Merged

make test network generic over peer type #3974

merged 1 commit into from
Dec 28, 2016

Conversation

rphmeier
Copy link
Contributor

Closes #3906

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 27, 2016
@rphmeier rphmeier requested a review from arkpar December 27, 2016 10:41
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 85.093% when pulling 84219a0 on mock-net into 7454212 on master.

tomusdrw
tomusdrw approved these changes Dec 28, 2016
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 28, 2016
@rphmeier
Copy link
Contributor Author

(merging due to review, CI, and uncontroversial change)

@rphmeier rphmeier merged commit 592a3ac into master Dec 28, 2016
@rphmeier rphmeier deleted the mock-net branch December 28, 2016 12:32
@rphmeier rphmeier mentioned this pull request Jan 10, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw approved these changes

@arkpar arkpar Awaiting requested review from arkpar

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
Light Client
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rphmeier @coveralls @tomusdrw