Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Store for EditPassword Modal #3979

Merged
merged 14 commits into from Dec 28, 2016
Merged

Store for EditPassword Modal #3979

merged 14 commits into from Dec 28, 2016

Conversation

jacogr
Copy link
Contributor

@jacogr jacogr commented Dec 27, 2016

@jacogr jacogr added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 27, 2016
ngotchac
ngotchac reviewed Dec 28, 2016
View reviewed changes
Copy link
Contributor

@ngotchac ngotchac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added a small fix to the EditMeta modal, where tags wasn't working anymore.

@ngotchac ngotchac added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 28, 2016
@gavofyork gavofyork merged commit 7e600b5 into master Dec 28, 2016
@gavofyork gavofyork deleted the jg-password-store branch December 28, 2016 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ngotchac ngotchac ngotchac left review comments

@derhuerst derhuerst Awaiting requested review from derhuerst

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jacogr @ngotchac @gavofyork