This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
eth_syncing, fixed #397 #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A8-looksgood 🦄
| SyncState::NotSynced | SyncState::Idle => SyncStatus::None, | ||
| SyncState::Waiting | SyncState::Blocks | SyncState::NewBlocks => SyncStatus::Info(SyncInfo { | ||
| starting_block: U256::from(status.start_block_number), | ||
| current_block: U256::from(status.last_imported_block_number.unwrap_or(status.start_block_number)), |
There was a problem hiding this comment.
this should be blockchain's best block
arkpar
added
A4-gotissues 💥
| @@ -49,10 +52,20 @@ impl Eth for EthClient { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: do no hardcode default sync status | |||
| fn syncing(&self, params: Params) -> Result<Value, Error> { | |||
There was a problem hiding this comment.
looks like pretty easy to test it
there is a dummy client spawn function in tests::helpers
There was a problem hiding this comment.
thanks, I will make a separate pr with api tests :)
debris
added
A0-pleasereview 🤓
arkpar
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.