This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix focus on Modal #4014
Merged
Fix focus on Modal #4014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacogr
reviewed
Jan 3, 2017
| @@ -49,6 +50,14 @@ class Modal extends Component { | |||
| waiting: PropTypes.array | |||
| } | |||
|
|
|||
| componentDidMount () { | |||
| const e = ReactDOM.findDOMNode(this.refs.dialog); | |||
There was a problem hiding this comment.
Would have preferred const element = ReactDOM... instead of the single e that could mean error, event, element, etc. (Not really gaining anything by being cryptic)
|
Can confirm that this fixes the tabbing problem. |
jacogr
added
A8-looksgood 🦄
|
Changes Unknown when pulling c708b3b on ng-fix-modal-focus into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3814
Focus on the Modal when it opens.