Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

show message on new chain #4016

Merged
merged 3 commits into from
Jan 3, 2017
Merged

show message on new chain #4016

merged 3 commits into from
Jan 3, 2017

Conversation

derhuerst
Copy link
Contributor

@derhuerst derhuerst added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M7-ui labels Jan 3, 2017
@derhuerst derhuerst added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jan 3, 2017
@derhuerst
Copy link
Contributor Author

derhuerst commented Jan 3, 2017 •
edited
Loading

Will add FormattedMessage. Out of scope of this PR.

Adding FormattedMessage to the middleware would dangerously entangle presentational & logical code. Also, Redux state is supposed to be serialisable & fully stateless.

One proper solution would be to pass the individual FormattedMessage props (like defaultMessage, id) into the state and construct the component when rendering.

@jacogr jacogr added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 3, 2017
@jacogr jacogr merged commit 9de8ba0 into master Jan 3, 2017
@jacogr jacogr deleted the jr-clear-on-new-chain branch January 3, 2017 16:41
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b97144e on jr-clear-on-new-chain into ** on master**.

@rphmeier rphmeier mentioned this pull request Jan 4, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derhuerst @coveralls @jacogr