Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Using local path on Windows #4017

Merged
merged 2 commits into from
Jan 5, 2017
Merged

Using local path on Windows #4017

merged 2 commits into from
Jan 5, 2017

Conversation

tomusdrw
Copy link
Collaborator

@tomusdrw tomusdrw commented Jan 3, 2017

Solves windows case of #1648
Windows users of version from master will need to move the chain data manualy from Roaming to Local.
Could also do with additional check on Windows machine (I've tested only on one VM)

@MicahZoltu Could you please verify that the location is sound now?

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Jan 3, 2017
@tomusdrw tomusdrw requested a review from arkpar January 3, 2017 14:03
@tomusdrw tomusdrw changed the title Using Local path on Windows Using local path on Windows Jan 3, 2017
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 012e7d3 on local-data into ** on master**.

db: replace_home(&data_dir, "$BASE/chains"),
db: replace_home_for_db(&data_dir, &local_dir,
if cfg!(target_os = "windows") { "$LOCAL/chains" }
else { "$BASE/chains" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is accomplished with the dir::CHAINS_PATH already, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that's a test code I wanted to have it more explicit here.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jan 3, 2017
@MicahZoltu
Copy link
Contributor

My Rust is pretty weak, but if I understand this change correctly it will make it so the chain data (the bulk of the on-disk storage) will land in AppDataType::UserCache (from that third party library)? If that is the case, I believe my primary concern is addressed here. If there is a desire, debate could be had about where the right place to put the other files are, or if ProgramData should be used instead (not currently exposed in that third party library). I am definitely up for going into more depth on what is "most correct" here, but I don't want to push my luck or prevent this change from going through, since it does address the most critical problem (roaming chain data).

@gavofyork gavofyork merged commit a076ffa into master Jan 5, 2017
@gavofyork gavofyork deleted the local-data branch January 5, 2017 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants