This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fixing minGasLimit > ceil limit mining issue #4018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
|
Changes Unknown when pulling b4678c3 on gas-adjustment into ** on master**. |
rphmeier
added
A8-looksgood 🦄
rphmeier
reviewed
Jan 3, 2017
| let gas_floor_target = ::std::cmp::max(gas_range_target.0, engine.params().min_gas_limit); | ||
| engine.populate_from_parent(&mut r.block.base.header, parent, gas_floor_target, gas_range_target.1); | ||
| let gas_floor_target = cmp::max(gas_range_target.0, engine.params().min_gas_limit); | ||
| let gas_ceil_target = cmp::max(gas_range_target.1, gas_floor_target); |
There was a problem hiding this comment.
looks fine to me except for the possible case where ceil < floor... at this point I'm not sure it's safe to assume anything :)
There was a problem hiding this comment.
It should still work fine even if you setup ceil < floor, that's the reason why it says max(gas_range_target.1, gas_floor_target) instead of max(gas_range.target.1, min_gas_limit).
In both cases min_gas_limit > floor > ceil and min_gas_limit > ceil > floor the gas should stay constant with value min_gas_limit.
gavofyork
approved these changes
Jan 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3760