Better error messages for PoA chains #4034
Conversation
|
It looks like @maciejhirsz hasn'signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement at the following URL: https://cla.ethcore.io Once you've signed, plesae reply to this thread with Many thanks, Ethcore CLA Bot |
| if engine_signer != Default::default() { | ||
| // Check if engine signer exists | ||
| if !account_provider.has_account(engine_signer).unwrap_or(false) { | ||
| return Err(format!("Consensus signer account not found for the current chain, please run `parity account new -d current-d --chain current-chain`")); |
There was a problem hiding this comment.
Is this info available in the RunCmd somewhere? Would be nice to format it in for adaptable error messages.
|
[clabot:check] |
|
It looks like @maciejhirsz signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
rphmeier
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 8ca0e09 on maciejhirsz:mh-pwmsg into ** on ethcore:master**. |
| } | ||
|
|
||
| if !passwords.iter().any(|p| account_provider.unlock_account_permanently(a, (*p).clone()).is_ok()) { | ||
| return Err(format!("No valid password to unlock account {}. Make sure valid password is present in files passed using `--password` or in the configuration file.", a)); |
There was a problem hiding this comment.
This (and other similar messages like on L#247) could be extracted to a constant.
There was a problem hiding this comment.
Or abstract out the checks in both places to a function?
rphmeier
added
A8-looksgood 🦄
|
Changes Unknown when pulling 516c41c on maciejhirsz:mh-pwmsg into ** on ethcore:master**. |
|
Updated according to suggestions from @keorn. Account creation hints are now adaptive:
|
|
Changes Unknown when pulling a4b4263 on maciejhirsz:mh-pwmsg into ** on ethcore:master**. |
Closes #4030